Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #9715: Simplify error message if test severity isn't 'warn' or 'error' #10015

Merged
merged 3 commits into from
Apr 23, 2024

Conversation

aranke
Copy link
Member

@aranke aranke commented Apr 23, 2024

resolves #9715

Problem

Error message is unintuitive if test severity is configured incorrectly.

Solution

Raise better error before JSON schema validation

Notes

Unit test is failing, this is expected because of this commit: dbt-labs/dbt-adapters@b61d66d

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@aranke aranke requested a review from a team as a code owner April 23, 2024 10:01
@cla-bot cla-bot bot added the cla:yes label Apr 23, 2024
Copy link

codecov bot commented Apr 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.14%. Comparing base (27943a5) to head (be2ab9f).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10015      +/-   ##
==========================================
- Coverage   88.17%   88.14%   -0.03%     
==========================================
  Files         181      181              
  Lines       22614    22617       +3     
==========================================
- Hits        19939    19935       -4     
- Misses       2675     2682       +7     
Flag Coverage Δ
integration 85.44% <66.66%> (-0.13%) ⬇️
unit 62.24% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aranke aranke added Impact: Exp artifact_minor_upgrade To bypass the CI check by confirming that the change is not breaking labels Apr 23, 2024
@aranke aranke merged commit 1014a6d into main Apr 23, 2024
62 checks passed
@aranke aranke deleted the fix_9715 branch April 23, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
artifact_minor_upgrade To bypass the CI check by confirming that the change is not breaking cla:yes Impact: Exp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make parsing error easier to understand
2 participants