Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove test_relation(moved to dbt-adapters) #10012

Merged
merged 1 commit into from
Apr 23, 2024
Merged

Conversation

ChenyuLInx
Copy link
Contributor

@ChenyuLInx ChenyuLInx commented Apr 23, 2024

#9961

Problem

this test is moved to dbt-adapters already, something changed and now dbt-core CI is broken.
This test was moved to dbt-adapters but not deleted in dbt-core repo. https://github.com/dbt-labs/dbt-adapters/blob/main/tests/unit/test_relation.py

Solution

@ChenyuLInx ChenyuLInx added the Skip Changelog Skips GHA to check for changelog file label Apr 23, 2024
@ChenyuLInx ChenyuLInx requested a review from a team as a code owner April 23, 2024 01:11
@cla-bot cla-bot bot added the cla:yes label Apr 23, 2024
Copy link

codecov bot commented Apr 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.12%. Comparing base (5c8a4ab) to head (575faaf).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10012      +/-   ##
==========================================
- Coverage   88.16%   88.12%   -0.04%     
==========================================
  Files         181      181              
  Lines       22593    22614      +21     
==========================================
+ Hits        19918    19928      +10     
- Misses       2675     2686      +11     
Flag Coverage Δ
integration 85.44% <ø> (-0.04%) ⬇️
unit 62.21% <ø> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@aranke aranke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@emmyoop emmyoop merged commit 27943a5 into main Apr 23, 2024
66 checks passed
@emmyoop emmyoop deleted the cl/remove_test_relation branch April 23, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants