Skip to content

Commit

Permalink
remove ~= from dependency definitions (#9640)
Browse files Browse the repository at this point in the history
* remove ~= from dependency definitions

* try lower bounds of alpha version

* Apply suggestions from code review

* Apply suggestions from code review
  • Loading branch information
emmyoop authored Feb 23, 2024
1 parent 12e40e2 commit d1ebf9d
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 11 deletions.
18 changes: 9 additions & 9 deletions core/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -49,18 +49,18 @@
# ----
# dbt-core uses these packages deeply, throughout the codebase, and there have been breaking changes in past patch releases (even though these are major-version-one).
# Pin to the patch or minor version, and bump in each new minor version of dbt-core.
"agate~=1.7.0",
"agate>=1.7.0,<1.8",
"Jinja2>=3.1.3,<4",
"mashumaro[msgpack]~=3.9",
"mashumaro[msgpack]>=3.9,<4.0",
# ----
# Legacy: This package has not been updated since 2019, and it is unused in dbt's logging system (since v1.0)
# The dependency here will be removed along with the removal of 'legacy logging', in a future release of dbt-core
"logbook>=1.5,<1.6",
# ----
# dbt-core uses these packages in standard ways. Pin to the major version, and check compatibility
# with major versions in each new minor version of dbt-core.
"click>=8.0.2,<9",
"networkx>=2.3,<4",
"click>=8.0.2,<9.0",
"networkx>=2.3,<4.0",
"requests<3.0.0", # should match dbt-common
# ----
# These packages are major-version-0. Keep upper bounds on upcoming minor versions (which could have breaking changes)
Expand All @@ -69,11 +69,11 @@
"sqlparse>=0.2.3,<0.5",
# ----
# These are major-version-0 packages also maintained by dbt-labs. Accept patches.
"dbt-extractor~=0.5.0",
"minimal-snowplow-tracker~=0.0.2",
"dbt-semantic-interfaces~=0.5.0a2",
"dbt-common~=0.1.6",
"dbt-adapters~=0.1.0a2",
"dbt-extractor>=0.5.0,<=0.6",
"minimal-snowplow-tracker>=0.0.2,<0.1",
"dbt-semantic-interfaces<1.0.0a1",
"dbt-common<1.0",
"dbt-adapters>=0.1.0a2,<1.0",
# ----
# Expect compatibility with all new versions of these packages, so lower bounds only.
"packaging>20.9",
Expand Down
4 changes: 2 additions & 2 deletions dev-requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,9 @@ mypy==1.4.1
pip-tools
pre-commit
protobuf>=4.0.0
pytest~=7.4
pytest>=7.4,<8.0
pytest-cov
pytest-csv~=3.0
pytest-csv>=3.0,<4.0
pytest-dotenv
pytest-logbook
pytest-mock
Expand Down

0 comments on commit d1ebf9d

Please sign in to comment.