Allow metrics in semantic layer filters (#9773)

* Tests for metrics in filters

* Bump DSI version

* Update test

* Changelog

.changes/unreleased/Features-20240322-103124.yaml

@@ -0,0 +1,6 @@
+kind: Features
+body: Allow metrics in semantic layer filters.
+time: 2024-03-22T10:31:24.76978-07:00
+custom:
+  Author: courtneyholcomb
+  Issue: "9804"

core/setup.py

@@ -73,7 +73,7 @@
         # Accept patches but avoid automatically updating past a set minor version range.
         "dbt-extractor>=0.5.0,<=0.6",
         "minimal-snowplow-tracker>=0.0.2,<0.1",
-        "dbt-semantic-interfaces>=0.5.0,<0.6",
+        "dbt-semantic-interfaces>=0.5.1,<0.6",
         # Minor versions for these are expected to be backwards-compatible
         "dbt-common<2.0",
         "dbt-adapters>=0.1.0a2,<2.0",

tests/functional/metrics/fixtures.py

@@ -88,6 +88,14 @@
       metrics:
         - average_tenure
       expr: "average_tenure + 1"
+
+  - name: tenured_people
+    label: Tenured People
+    description: People who have been here more than 1 year
+    type: simple
+    type_params:
+      measure: people
+    filter: "{{ Metric('collective_tenure', ['id']) }} > 2"
 """
 
 metricflow_time_spine_sql = """

tests/functional/saved_queries/fixtures.py

@@ -17,6 +17,7 @@
         where:
             - "{{ Dimension('user__ds', 'DAY') }} <= now()"
             - "{{ Dimension('user__ds', 'DAY') }} >= '2023-01-01'"
+            - "{{ Metric('txn_revenue', ['id']) }} > 1"
     exports:
         - name: my_export
           config:

tests/functional/saved_queries/test_saved_query_parsing.py

@@ -41,7 +41,7 @@ def test_semantic_model_parsing(self, project):
         assert saved_query.name == "test_saved_query"
         assert len(saved_query.query_params.metrics) == 1
         assert len(saved_query.query_params.group_by) == 1
-        assert len(saved_query.query_params.where.where_filters) == 2
+        assert len(saved_query.query_params.where.where_filters) == 3
         assert len(saved_query.depends_on.nodes) == 1
         assert saved_query.description == "My SavedQuery Description"
         assert len(saved_query.exports) == 1