Fix manage_schemas parsing from profile

dbt-labs · Jun 17, 2022 · 1751ce0 · 1751ce0
1 parent 81a7f00
commit 1751ce0
Show file tree

Hide file tree

Showing 7 changed files with 18 additions and 82 deletions.
diff --git a/core/dbt/config/profile.py b/core/dbt/config/profile.py
@@ -360,7 +360,7 @@ def from_raw_profile_info(
             target_name=target_name,
             threads=threads,
             user_config=user_config,
-            manage_schemas=False,  # TODO
+            manage_schemas=profile_data.get("manage_schemas", False),
         )
 
     @classmethod

diff --git a/core/dbt/task/run.py b/core/dbt/task/run.py
@@ -24,6 +24,7 @@
 from dbt.contracts.results import NodeStatus, RunResult, RunStatus, RunningStatus
 from dbt.exceptions import (
     warn_or_error,
+    warn,
     CompilationException,
     InternalException,
     RuntimeException,
@@ -499,6 +500,7 @@ def manage_schema(self, adapter, results: List[RunResult]):
 
         if not manage_schemas_config:
             # TODO debug not doing anything
+            warn("Schema's configured to be managed, but manage_schemas is false in the profile")
             return
 
         if len(managed_schemas_actions_config) == 0:

diff --git a/test/integration/077_schema_management_tests/models/my_first_dbt_model.sql b/test/integration/077_schema_management_tests/models/my_first_dbt_model.sql
diff --git a/test/integration/077_schema_management_tests/models/schema.yml b/test/integration/077_schema_management_tests/models/schema.yml
diff --git a/test/integration/077_schema_management_tests/test_local_dependency.py b/test/integration/077_schema_management_tests/test_local_dependency.py
diff --git a/test/integration/077_schema_management_tests/update.sql b/test/integration/077_schema_management_tests/update.sql
diff --git a/tests/functional/schema_management/test_drop_dangling_models.py b/tests/functional/schema_management/test_drop_dangling_models.py
@@ -1,32 +1,30 @@
 import pytest
 import os
 
-from dbt.tests.util import run_dbt, check_table_does_exist, check_table_does_not_exist, write_file
+from dbt.tests.util import (
+    run_dbt,
+    check_table_does_exist,
+    check_table_does_not_exist,
+)
 
 model = """
 {{
   config(
     materialized = "table"
   )
 }}
-
-with source_data as (
-
-        select 1 as id
-union all
-select null as id
-
-)
-
-select *
-from source_data
+SELECT * FROM (
+VALUES (1, 'one'),
+ (2, 'two'),
+ (3, 'three')
+) AS t (num,letter)
 """
 
 
 @pytest.fixture(scope="class")
 def models():
     return {
-        "users.sql": model,
+        "numbers.sql": model,
     }
 
 
@@ -61,12 +59,12 @@ def test_drop(
         self,
         project,
     ):
-        # create users model
+        # create numbers model
         run_dbt(["run"])
-        check_table_does_exist(project.adapter, "users")
+        check_table_does_exist(project.adapter, "numbers")
         check_table_does_not_exist(project.adapter, "baz")
 
-        # remove users model
+        # remove numbers model
         project.update_models({})
         run_dbt(["run"])
-        check_table_does_not_exist(project.adapter, "users")
+        check_table_does_not_exist(project.adapter, "numbers")