Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core -> common testing #54

Merged
merged 43 commits into from
Feb 6, 2024
Merged

core -> common testing #54

merged 43 commits into from
Feb 6, 2024

Conversation

emmyoop
Copy link
Member

@emmyoop emmyoop commented Jan 31, 2024

resolves #18

Description

Adds workflow to test specific dbt-core branches against specific dbt-common branches.

  • can be triggered:
    • manually
    • via a workflow
    • on merge
    • on pull_request - only runs unit tests

We only run unit tests on pull requests to reduce the time it takes to test. The entire core test suite will run on merge to ensure nothing is broken before fully merging into main.

Also adds stub for scheduled testing with alerts in slack on failures. Test will be added in #62 once proper auths are in place.

Checklist

@emmyoop emmyoop requested a review from a team as a code owner January 31, 2024 20:14
@emmyoop emmyoop requested a review from gshank January 31, 2024 20:14
@codecov-commenter
Copy link

codecov-commenter commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (af14523) 51.47% compared to head (bda211e) 51.47%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #54   +/-   ##
=======================================
  Coverage   51.47%   51.47%           
=======================================
  Files          49       49           
  Lines        2856     2856           
=======================================
  Hits         1470     1470           
  Misses       1386     1386           
Flag Coverage Δ
unit 51.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmyoop emmyoop marked this pull request as draft January 31, 2024 20:17
@emmyoop emmyoop force-pushed the er/18-core-testing branch from 337bc3f to e3b2ac1 Compare January 31, 2024 20:19
@emmyoop emmyoop changed the title core -> common testsing core -> common testing Feb 1, 2024
@emmyoop emmyoop added the Skip Changelog Skips GHA to check for changelog file label Feb 1, 2024
@emmyoop emmyoop force-pushed the er/18-core-testing branch from aa3e4a0 to 9359290 Compare February 1, 2024 20:06
@emmyoop emmyoop mentioned this pull request Feb 5, 2024
5 tasks
@emmyoop emmyoop force-pushed the er/18-core-testing branch from d8af7a9 to b69cfbd Compare February 5, 2024 14:22
@emmyoop emmyoop marked this pull request as ready for review February 5, 2024 14:32
@emmyoop emmyoop force-pushed the er/18-core-testing branch from 7405e15 to 49a0757 Compare February 5, 2024 16:31
Copy link
Collaborator

@MichelleArk MichelleArk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good! Should we expect the on-merge integration tests to run as soon as we merge this, or should we test that in a follow-up?

@emmyoop
Copy link
Member Author

emmyoop commented Feb 6, 2024

@MichelleArk I believe in the follow up. It's why i haven't pushed for a review of #51 - saving it to test the on merge functionality.

@emmyoop emmyoop added this pull request to the merge queue Feb 6, 2024
Merged via the queue into main with commit 50555ee Feb 6, 2024
11 checks passed
@emmyoop emmyoop deleted the er/18-core-testing branch February 6, 2024 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set up testing between branches of dbt-core and dbt-common
3 participants