-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core -> common testing #54
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #54 +/- ##
=======================================
Coverage 51.47% 51.47%
=======================================
Files 49 49
Lines 2856 2856
=======================================
Hits 1470 1470
Misses 1386 1386
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
337bc3f
to
e3b2ac1
Compare
aa3e4a0
to
9359290
Compare
d8af7a9
to
b69cfbd
Compare
7405e15
to
49a0757
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good! Should we expect the on-merge integration tests to run as soon as we merge this, or should we test that in a follow-up?
@MichelleArk I believe in the follow up. It's why i haven't pushed for a review of #51 - saving it to test the on merge functionality. |
resolves #18
Description
Adds workflow to test specific
dbt-core
branches against specificdbt-common
branches.We only run unit tests on pull requests to reduce the time it takes to test. The entire core test suite will run on merge to ensure nothing is broken before fully merging into main.
Also adds stub for scheduled testing with alerts in slack on failures. Test will be added in #62 once proper auths are in place.
Checklist
changie new
to create a changelog entry