Inject TagIterator into BlockIterator #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterallenwebb
changed the title
MichelleArk
reviewed
Jan 23, 2024
dbt_common/clients/_jinja_blocks.py
Outdated
| @@ -98,22 +98,22 @@ def end_pat(self): | |||
|
|
|||
|
|
|||
| class TagIterator: | |||
| def __init__(self, data): | |||
| self.data = data | |||
| def __init__(self, text): | |||
There was a problem hiding this comment.
while we're here and have context, would you mind adding some type annotations? lots to backfill in this repo!
There was a problem hiding this comment.
thank you thank you! ✨
MichelleArk
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #38
Checklist
changie newto create a changelog entry