Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update behavior deprecation flags to be behavior change flags #193

Merged
merged 6 commits into from
Sep 18, 2024

Conversation

mikealfare
Copy link
Contributor

@mikealfare mikealfare commented Sep 17, 2024

Description

Behavior changes are not always behavior deprecation changes. However, a lot of the verbiage and messaging around behavior flags suggested they only support deprecating changes. This PR updates this verbiage to allow for more types of behavior changes, e.g. changing how we do something (pg_catalog usage in dbt-redshift) or allowing users to opt-in to new features that will be fully supported in dbt as the data platform matures the feature (Iceberg usage in dbt-snowflake).

I'm adding Skip Changelog as the intent is already captured in a previous changelog; it would be duplicative.

Checklist

@mikealfare mikealfare self-assigned this Sep 17, 2024
@mikealfare mikealfare requested a review from a team as a code owner September 17, 2024 21:51
@cla-bot cla-bot bot added the cla:yes label Sep 17, 2024
@mikealfare mikealfare added Skip Changelog Skips GHA to check for changelog file and removed cla:yes labels Sep 17, 2024
Copy link

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@codecov-commenter
Copy link

codecov-commenter commented Sep 17, 2024

Codecov Report

Attention: Patch coverage is 25.42373% with 44 lines in your changes missing coverage. Please review.

Project coverage is 65.18%. Comparing base (9798ca7) to head (215fe50).

Files with missing lines Patch % Lines
dbt_common/events/types_pb2.py 2.22% 44 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #193      +/-   ##
==========================================
+ Coverage   65.16%   65.18%   +0.01%     
==========================================
  Files          52       52              
  Lines        3333     3323      -10     
==========================================
- Hits         2172     2166       -6     
+ Misses       1161     1157       -4     
Flag Coverage Δ
unit 65.18% <25.42%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cla-bot cla-bot bot added the cla:yes label Sep 17, 2024
@mikealfare mikealfare added this pull request to the merge queue Sep 18, 2024
Merged via the queue into main with commit e5dff92 Sep 18, 2024
16 checks passed
@mikealfare mikealfare deleted the behavior-change-flags branch September 18, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants