-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make extract_top_level_blocks() faster #189
Make extract_top_level_blocks() faster #189
Conversation
Credit should really go to @peterallenwebb BTW for the original PR in |
7b6978b
to
14cef17
Compare
14cef17
to
21a1c31
Compare
Hi @dbeatty10! Do you know if there is a chance to get this merged into the next release of I just rebased my branch on the latest |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #189 +/- ##
==========================================
+ Coverage 68.33% 68.48% +0.14%
==========================================
Files 52 52
Lines 3373 3389 +16
==========================================
+ Hits 2305 2321 +16
Misses 1068 1068
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…faster. Duplicate the change from dbt-labs/dbt-core#9045 into dbt-common
a70f349
to
a45798c
Compare
Updated my branch with latest changes in |
Closed in favor of #205 |
Resolves dbt-labs/dbt-core#9037
Description
This PR improves the performance of parsing docs files.
Duplicates the change from dbt-labs/dbt-core#9045 into dbt-common
Have verified the performance improvement in our local dbt project (~2300 models). Full parse time on my M1 Mac went from 2m20s to 41s.
Checklist
changie new
to create a changelog entry