Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More Type Annotations #177

Merged
merged 3 commits into from
Aug 1, 2024
Merged

More Type Annotations #177

merged 3 commits into from
Aug 1, 2024

Conversation

peterallenwebb
Copy link
Contributor

Checklist

@peterallenwebb peterallenwebb added Skip Changelog Skips GHA to check for changelog file tidy_first labels Aug 1, 2024
@peterallenwebb peterallenwebb requested a review from a team as a code owner August 1, 2024 15:24
@cla-bot cla-bot bot added the cla:yes label Aug 1, 2024
@codecov-commenter
Copy link

codecov-commenter commented Aug 1, 2024

Codecov Report

Attention: Patch coverage is 96.29630% with 1 line in your changes missing coverage. Please review.

Project coverage is 64.34%. Comparing base (bef3b7d) to head (098c9ea).

Files Patch % Lines
dbt_common/contracts/config/base.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #177      +/-   ##
==========================================
+ Coverage   64.33%   64.34%   +0.01%     
==========================================
  Files          51       51              
  Lines        3230     3231       +1     
==========================================
+ Hits         2078     2079       +1     
  Misses       1152     1152              
Flag Coverage Δ
unit 64.34% <96.29%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gshank
Copy link
Contributor

gshank commented Aug 1, 2024

Need to fix this though: E ImportError: cannot import name 'Self' from 'typing'

@peterallenwebb peterallenwebb added this pull request to the merge queue Aug 1, 2024
Merged via the queue into main with commit c9cc99e Aug 1, 2024
20 checks passed
@peterallenwebb peterallenwebb deleted the paw/types-tidy-5 branch August 1, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file tidy_first
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants