Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some type annotations #156

Merged
merged 2 commits into from
Jul 30, 2024
Merged

Add some type annotations #156

merged 2 commits into from
Jul 30, 2024

Conversation

peterallenwebb
Copy link
Contributor

Description

Add some type annotations

Checklist

@peterallenwebb peterallenwebb added Skip Changelog Skips GHA to check for changelog file tidy_first labels Jun 25, 2024
@peterallenwebb peterallenwebb requested a review from a team as a code owner June 25, 2024 22:22
@cla-bot cla-bot bot added the cla:yes label Jun 25, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.33%. Comparing base (db99ddd) to head (59c8a9e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #156      +/-   ##
==========================================
+ Coverage   64.31%   64.33%   +0.02%     
==========================================
  Files          51       51              
  Lines        3228     3230       +2     
==========================================
+ Hits         2076     2078       +2     
  Misses       1152     1152              
Flag Coverage Δ
unit 64.33% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@QMalcolm QMalcolm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@peterallenwebb peterallenwebb added this pull request to the merge queue Jun 25, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jun 25, 2024
@peterallenwebb peterallenwebb added this pull request to the merge queue Jun 26, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jun 26, 2024
@peterallenwebb peterallenwebb added this pull request to the merge queue Jul 30, 2024
Merged via the queue into main with commit bef3b7d Jul 30, 2024
20 checks passed
@peterallenwebb peterallenwebb deleted the paw/types-tidy-2 branch July 30, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file tidy_first
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants