-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use fastjsonschema instead of jsonschema for validation #146
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #146 +/- ##
==========================================
+ Coverage 64.33% 64.78% +0.45%
==========================================
Files 51 51
Lines 3230 3243 +13
==========================================
+ Hits 2078 2101 +23
+ Misses 1152 1142 -10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
# former message: "'name' is a required property" | ||
assert ( | ||
excinfo.value.message | ||
== "Invalid value '{'an_attr': 'fubar'}': data must contain ['name'] properties" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the other error message look good - essentially saying X is invalid because of Y.
In the case, the invalid value '{'an_attr': 'fubar'}'
is invalid because it's missing 1 or more properties. I think it's probably still helpful to name the invalid value (so users can identify where they need to go add the missing properties), so I feel good about this one as well.
resolves #145
Description
For performance reasons we are replacing jsonschema with fastjsonschema.
Checklist
changie new
to create a changelog entry