[TIDY FIRST] Remove conditional typing_extensions import for python < 3.8
#134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This repository doesn't currently, and never has, supported python versions less than 3.8. The conditional import being removed here is a holdover from when this code was cut out of dbt-core (which no longer supports python less than 3.8 either).
ChenyuLInx
approved these changes
May 15, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #134 +/- ##
=======================================
Coverage 56.37% 56.37%
=======================================
Files 50 50
Lines 3090 3088 -2
=======================================
- Hits 1742 1741 -1
+ Misses 1348 1347 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
We do still support python 3.8 in core, and we also support python 3.8 here. However this change only effects python versions less than 3.8 which neither dbt-common nor dbt-core support |
QMalcolm
deleted the
qmalcolm--tidy-first-remove-condition-imports-for-below-python3.8
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This repository doesn't currently, and never has, supported python versions less than 3.8. The conditional import being removed here is a holdover from when this code was cut out of dbt-core (which no longer supports python less than 3.8 either).
Checklist
I have opened an issue to add/update docs, or docs changes are not required/relevant for this PRI have runchangie newto create a changelog entry