A method to add callbacks to the global event manager #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We did this refactor because we plan to use the `EventCatcher` in more unit test files. We have a similar class in dbt-core currently. It might be worthwhile at a future date to distribute this class via the `dbt_common` package itself. Also the empty `__init__.py` files are unfortunately necessary it seems. This is because without them mypy will complain about "Source file found twice under different module names".
We had done this work previously by ignoring event classes that came from modules beginning with `test_`. This worked because if we created or re-implemented events in test files, their module was the the file that they existed in. However, in the previous commit 4d34929, we added `__init__.py` files to the directories under `tests`. This made it so that the events that we were previously successfully ignoring had their module updated to their full path, i.e. `tests.unit.<file_name>`, and thus their module no longer began with `test_`, but `tests.` instead. Because of this, we had a regression that caused the previously corrected tests to begin failing again. This commit fixes that.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #132 +/- ##
==========================================
+ Coverage 56.29% 56.37% +0.08%
==========================================
Files 50 50
Lines 3082 3090 +8
==========================================
+ Hits 1735 1742 +7
- Misses 1347 1348 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
MichelleArk
approved these changes
May 15, 2024
QMalcolm
deleted the
qmalcolm--131-method-to-add-callbacks-to-event-manager
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #131
Description
It was annoying me that we had a way to add loggers to the global event manager but not callbacks. I'm doing work in dbt-core that could benefit from this. So I decided to do the work here to give callbacks the same support as loggers.
Checklist
changie newto create a changelog entry