Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation of the design and intent of the record/replay mechanism. #129

Merged
merged 7 commits into from
May 10, 2024

Conversation

peterallenwebb
Copy link
Contributor

No description provided.

@peterallenwebb peterallenwebb requested a review from a team as a code owner May 9, 2024 14:56
@cla-bot cla-bot bot added the cla:yes label May 9, 2024
Copy link

github-actions bot commented May 9, 2024

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@codecov-commenter
Copy link

codecov-commenter commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.29%. Comparing base (039edf2) to head (a941188).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #129   +/-   ##
=======================================
  Coverage   56.29%   56.29%           
=======================================
  Files          50       50           
  Lines        3082     3082           
=======================================
  Hits         1735     1735           
  Misses       1347     1347           
Flag Coverage Δ
unit 56.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@peterallenwebb peterallenwebb added the Skip Changelog Skips GHA to check for changelog file label May 9, 2024
Copy link
Member

@emmyoop emmyoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly spell check. One request to add a comment about the current state being experimental. Otherwise this is great! Nice details.

dbt_common/record.py Outdated Show resolved Hide resolved
docs/guides/record_replay.md Outdated Show resolved Hide resolved
docs/guides/record_replay.md Outdated Show resolved Hide resolved
docs/guides/record_replay.md Outdated Show resolved Hide resolved
docs/guides/record_replay.md Outdated Show resolved Hide resolved
docs/guides/record_replay.md Outdated Show resolved Hide resolved
docs/guides/record_replay.md Outdated Show resolved Hide resolved
docs/guides/record_replay.md Show resolved Hide resolved
peterallenwebb and others added 2 commits May 10, 2024 10:45
@peterallenwebb peterallenwebb enabled auto-merge May 10, 2024 14:50
@peterallenwebb peterallenwebb added this pull request to the merge queue May 10, 2024
Merged via the queue into main with commit df4b4c0 May 10, 2024
18 checks passed
@peterallenwebb peterallenwebb deleted the paw/record-docs branch May 10, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants