Skip to content

Commit

Permalink
update test name + readme paths
Browse files Browse the repository at this point in the history
  • Loading branch information
MichelleArk committed Jan 10, 2024
1 parent fb02009 commit c635883
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions dbt_common/events/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ When events are processed via `fire_event`, nearly everything is logged. Whether
# Adding a New Event
* Add a new message in types.proto, and a second message with the same name + "Msg". The "Msg" message should have two fields, an "info" field of EventInfo, and a "data" field referring to the message name without "Msg"
* run the protoc compiler to update types_pb2.py: make proto_types
* Add a wrapping class in core/dbt/event/types.py with a Level superclass plus code and message methods
* Add a wrapping class in dbt_common/event/types.py with a Level superclass plus code and message methods
* Add the class to tests/unit/test_events.py

We have switched from using betterproto to using google protobuf, because of a lack of support for Struct fields in betterproto.
Expand Down Expand Up @@ -38,4 +38,4 @@ class PartialParsingDeletedExposure(DebugLevel):

After adding a new message in `types.proto`, either:
- In the repository root directory: `make proto_types`
- In the `core/dbt/common/events` directory: `protoc -I=. --python_out=. types.proto`
- In the `dbt_common/events` directory: `protoc -I=. --python_out=. types.proto`
2 changes: 1 addition & 1 deletion tests/unit/test_core_dbt_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
from dbt_common.utils.connection import connection_exception_retry


class TestCoreDbtUtils(unittest.TestCase):
class TestCommonDbtUtils(unittest.TestCase):
def test_connection_exception_retry_none(self):
Counter._reset()
connection_exception_retry(lambda: Counter._add(), 5)
Expand Down

0 comments on commit c635883

Please sign in to comment.