Skip to content

Commit

Permalink
Add CODEOWNERS (#28)
Browse files Browse the repository at this point in the history
* add codeowners

* add merge queue logic

* link to specific ticket
  • Loading branch information
emmyoop authored Jan 25, 2024
1 parent 5ce19dd commit 31804b1
Show file tree
Hide file tree
Showing 5 changed files with 74 additions and 1 deletion.
14 changes: 14 additions & 0 deletions .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
# This file contains the code owners for the dbt-common repo.
# PRs will be require review from the associated
# team(s) or person(s) that touches any files that are mapped to them.
#
# A statement takes precedence over the statements above it so more general
# assignments are found at the top with specific assignments being lower in
# the ordering (i.e. catch all assignment should be the first item)
#
# Consult GitHub documentation for formatting guidelines:
# https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners#example-of-a-codeowners-file

# As a default for areas with no assignment,
# the core team as a whole will be assigned
* @dbt-labs/core-team
2 changes: 2 additions & 0 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ on:
branches:
- "main"
pull_request:
merge_group:
types: [checks_requested]
workflow_dispatch:

permissions: read-all
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/ci_code_quality.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ on:
branches:
- "main"
pull_request:
merge_group:
types: [checks_requested]
workflow_dispatch:

permissions: read-all
Expand Down
53 changes: 53 additions & 0 deletions .github/workflows/ci_dbt_core_testing.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,53 @@
# **what?**
# Runs all tests in dbt-core with this branch of dbt-common to ensure nothing is broken

# **why?**
# Ensure dbt-common changes do nto break dbt-core

# **when?**
# This will run when trying to merge a PR into main.
# It can also be manually triggered.

## TODO: This is a stub. It does nothing right now.
# It will be updated in the future as part of https://github.com/dbt-labs/dbt-common/issues/18

name: Test Against dbt-core

on:
merge_group:
types: [checks_requested]
workflow_dispatch:

permissions: read-all

defaults:
run:
shell: bash

jobs:
test-dbt-core:
name: "This does nothing right now - always passes"

runs-on: ubuntu-latest
timeout-minutes: 10

steps:
- name: "Check out dbt-core"
uses: actions/checkout@v3

- name: "Set up Python 3.11"
uses: actions/setup-python@v4
with:
python-version: "3.11"

- name: "Update the version of dbt-common"
run: |
echo "Update the version of dbt-common ref'd in dbt-core"
- name: "Install dbt-core"
run: |
echo "Install dbt-core with updated dbt-common ref"
- name: "Run Tests"
run: |
echo "Running tests in future versions."
4 changes: 3 additions & 1 deletion .github/workflows/ci_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ on:
branches:
- "main"
pull_request:
merge_group:
types: [checks_requested]
workflow_dispatch:

permissions: read-all
Expand Down Expand Up @@ -48,7 +50,7 @@ jobs:
- name: "Set up Python ${{ matrix.python-version }}"
uses: actions/setup-python@v5
with:
python-version: ${{ matrix.python-version }}
python-version: "${{ matrix.python-version }}"

- name: "Install Hatch"
shell: bash
Expand Down

0 comments on commit 31804b1

Please sign in to comment.