Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow base model creation to take multiple tables as arguments #225

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Eromtap
Copy link

@Eromtap Eromtap commented Nov 25, 2024

resolves #233

Description & motivation

Base model creation would not accept more than one table name. Altered base_model_creation.sh to iterate thru args and call generate_base_model macro for each one.

Checklist

  • This code is associated with an issue which has been triaged and accepted for development.
  • I have verified that these changes work locally
  • I have updated the README.md (if applicable)
  • I have added tests & descriptions to my models (and macros if applicable)
  • I have added an entry to CHANGELOG.md

Base model creation would not accept more than one table name. Altered base_model_creation.sh to iterate thru args and call generate_base_model macro for each one
Corrected bash command to work with new base_model_creation.sh
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Nov 25, 2024
@dbeatty10
Copy link
Contributor

I like the way you are thinking @Eromtap 🤩

Could you open a feature request for this here?

@dbeatty10 dbeatty10 changed the title Base model creation fix Allow base model creation to take multiple tables as arguments Dec 5, 2024
@dbeatty10
Copy link
Contributor

@Eromtap This bash script was originally added in #83, and it was intended to pair up with the create_base_models macro.

Do you know if a command like this would still work after your proposed changes?

dbt run-operation codegen.create_base_models --args '{"source_name": "dbt_dbeatty", "tables": ["raw_orders", "raw_customers", "asdfasdf"]}'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow base model creation to take multiple tables as arguments
2 participants