Allow base model creation to take multiple tables as arguments #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base model creation would not accept more than one table name. Altered base_model_creation.sh to iterate thru args and call generate_base_model macro for each one
Corrected bash command to work with new base_model_creation.sh
dosubot
bot
added
the
size:S
dbeatty10
changed the title
|
@Eromtap This bash script was originally added in #83, and it was intended to pair up with the Do you know if a command like this would still work after your proposed changes? dbt run-operation codegen.create_base_models --args '{"source_name": "dbt_dbeatty", "tables": ["raw_orders", "raw_customers", "asdfasdf"]}' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #233
Description & motivation
Base model creation would not accept more than one table name. Altered
base_model_creation.shto iterate thru args and callgenerate_base_modelmacro for each one.Checklist