Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix insert_overwrite incremental strategy in combination with required partition_filter fails when there are zero rows to insert #994

Conversation

tnk-ysk
Copy link
Contributor

@tnk-ysk tnk-ysk commented Oct 28, 2023

resolves #319
docs dbt-labs/docs.getdbt.com/#

Problem

If a model has incremental strategy and set to , an incremental run that tries to add zero (0) rows will fail and return from BigQuery.

Solution

Avoid require partition filter by adding partition is null or partition is not null to the merge condition.
Same solution as #986

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

…d partition_filter fails when there are zero rows to insert
@tnk-ysk tnk-ysk requested a review from a team as a code owner October 28, 2023 13:19
@tnk-ysk tnk-ysk requested a review from nathaniel-may October 28, 2023 13:19
@cla-bot cla-bot bot added the cla:yes label Oct 28, 2023
@tnk-ysk tnk-ysk marked this pull request as draft November 5, 2023 05:35
@tnk-ysk tnk-ysk closed this Feb 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant