a slight rework of 955 to keep a seperation of concerns #957
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #
docs dbt-labs/docs.getdbt.com/#
Problem
we implemented a change in #955 to fix query_header in doing so moved
self.query_header
into the same conditional logic asself.profile
and used a walrus operator to assign and check which while clean does make parse code quickly slightly harder.Solution
to functionalize the small snippet and create a small change by making it to two nested if statements and moving the empty set of variable to top of function.
Checklist