Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

poll .GetBatch() instead of using operation.result() #929

Merged
merged 19 commits into from
Sep 26, 2023

Conversation

colin-rogers-dbt
Copy link
Contributor

@colin-rogers-dbt colin-rogers-dbt commented Sep 19, 2023

  • re:PR 738/wazi #840
  • adding back comment # check if job failed
  • adding changelog
  • precommit code format
  • sleep(2) first in the while loop before the request to eliminate the last 2 seconds sleep if the response is in one of the 3 options
  • removing empty spaces
  • update batch request to handle GetBatchRequest

resolves #734
docs dbt-labs/docs.getdbt.com/#

Problem

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@colin-rogers-dbt colin-rogers-dbt requested a review from a team as a code owner September 19, 2023 04:07
@cla-bot cla-bot bot added the cla:yes label Sep 19, 2023
@colin-rogers-dbt colin-rogers-dbt requested review from mikealfare and a team September 22, 2023 21:12
dbt/adapters/bigquery/dataproc/batch.py Outdated Show resolved Hide resolved
dbt/adapters/bigquery/dataproc/batch.py Show resolved Hide resolved
dbt/adapters/bigquery/dataproc/batch.py Show resolved Hide resolved
dbt/adapters/bigquery/dataproc/batch.py Outdated Show resolved Hide resolved
dbt/adapters/bigquery/dataproc/batch.py Outdated Show resolved Hide resolved
@colin-rogers-dbt colin-rogers-dbt merged commit e5a89af into main Sep 26, 2023
24 checks passed
@colin-rogers-dbt colin-rogers-dbt deleted the pollGetBatchForPython branch September 26, 2023 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants