Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add allow_non_incremental_definition #1417

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

yu-iskw
Copy link
Contributor

@yu-iskw yu-iskw commented Nov 29, 2024

resolves #672

Problem

We can't create non-incremental materialized views with dbt-bigquery today.

The other developers tried to add the feature. But, it seems that

Solution

We are supporting the allow_non_incremental_definition option to create a materialized view.

{{ config(
    materialized='materialized_view',
    refresh_interval_minutes=60,
    max_staleness="INTERVAL 45 MINUTE",
    allow_non_incremental_definition=True
) }}

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@cla-bot cla-bot bot added the cla:yes label Nov 29, 2024
Signed-off-by: Yu Ishikawa <[email protected]>
@yu-iskw yu-iskw marked this pull request as ready for review November 29, 2024 03:36
@yu-iskw yu-iskw requested a review from a team as a code owner November 29, 2024 03:36
@yu-iskw
Copy link
Contributor Author

yu-iskw commented Dec 4, 2024

@colin-rogers-dbt I don't want to bother you, but I appreciate if you could take a look at the pull request. Thanks.

@yu-iskw
Copy link
Contributor Author

yu-iskw commented Dec 11, 2024

@mikealfare I appreciate if you could share your thoughts on the pull request. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ADAP-464] Materialized Views - Non-incremental support
1 participant