-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow base64-service-account-json key auth Issue: #923 #1245
Allow base64-service-account-json key auth Issue: #923 #1245
Conversation
Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA. In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR. CLA has not been signed by users: @rbaker1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @rbaker1! The change looks straightforward, especially with the tests you've added. I left one nit about method naming. Otherwise, this lgtm; I'd like an engineer from the team to review before we merge this in. I also added the user docs
label because we'll need to open an issue for updating these docs on BQ connections.
It's my pleasure - should I make the doc update issue or will another member? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docs issue should be opened automatically when this PR is merged!
fyi - I'm going to close and reopen the PR to re-trigger the expected tests |
@cla-bot check |
I signed off on the cla weeks ago :S |
@cla-bot check |
yea it's a little temperamental sometimes |
Bypassing stuck cla-bot check |
Opened a new issue in dbt-labs/docs.getdbt.com: dbt-labs/docs.getdbt.com#5640 |
resolves #923
Problem
Currently, JSON key files can only be represented as a string. There is interest in being able to set the GCP service account as a base64 encoded string.
Solution
The user can input either a base54 represented JSON key file or a normal string. There is testing involved to ensure it is invoked correctly.
Checklist