-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADAP-1051 - Temp Table Drop Fix #1076
Conversation
Fix for ADAP-1051
Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA. In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR. CLA has not been signed by users: @vinit2107 |
I have signed the CLA. Please let me know if I need to do anything else. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good so far @vinit2107 !
I made two code suggestions to address and then we can queue it up for review by an engineer.
Thanks @dbeatty10 for your input 👍🏻 I have made the recommended changes. |
Hey @vinit2107 , thank you so much for this contribution. We had some time to assess this one and I think it looks great. I'm really happy we have this fix as opposed to one that just adds another flag on top of the already existing I'll have this merged on Monday :) |
resolves #1036
resolves #1051
Problem
Temp tables created by DBT in BigQuery in incremental strategy were not dropped after successful execution.
Solution
I have added handling for two scenarios:
Checklist