Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dataproc Job options in model config #1048

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

gbmarc1
Copy link

@gbmarc1 gbmarc1 commented Dec 7, 2023

Problem

For a given model, it was required to further configure the pyspark job. We are adding config properties to do so.

Solution

In the _submit_dataproc_job method of the ClusterDataprocHelper we are reading optional dataproc_pyspark_job field. This field is an object with the following schema.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@gbmarc1 gbmarc1 requested a review from a team as a code owner December 7, 2023 02:06
@cla-bot cla-bot bot added the cla:yes label Dec 7, 2023
Copy link

cla-bot bot commented Dec 7, 2023

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR.

CLA has not been signed by users: @gbmarc1

@cla-bot cla-bot bot removed the cla:yes label Dec 7, 2023
@cla-bot cla-bot bot added the cla:yes label Dec 7, 2023
@nathaniel-may
Copy link
Contributor

Hi @gbmarc1, thanks for opening this PR. The next steps are to create a feature request issue for this and link them so we can make any design considerations first.

@gbmarc1
Copy link
Author

gbmarc1 commented Jan 4, 2024

Thank you @nathaniel-may,
I created this issue.

@gbmarc1
Copy link
Author

gbmarc1 commented Mar 12, 2024

@nathaniel-may Just pinging

@Fleid
Copy link
Contributor

Fleid commented Mar 14, 2024

Hey @gbmarc1, could you please add tests to the PR?

@gbmarc1
Copy link
Author

gbmarc1 commented Mar 15, 2024

@Fleid I would be happy to add test about the added functionality. But I cannot find any test for class ClusterDataprocHelper or the python_submission file. Could you point me to them if I am not missing anything?

@Fleid
Copy link
Contributor

Fleid commented Mar 20, 2024

@dataders would you happen to know that? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants