-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dataproc Job options in model config #1048
base: main
Are you sure you want to change the base?
Conversation
Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA. In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR. CLA has not been signed by users: @gbmarc1 |
Hi @gbmarc1, thanks for opening this PR. The next steps are to create a feature request issue for this and link them so we can make any design considerations first. |
Thank you @nathaniel-may, |
@nathaniel-may Just pinging |
Hey @gbmarc1, could you please add tests to the PR? |
@Fleid I would be happy to add test about the added functionality. But I cannot find any test for class |
@dataders would you happen to know that? :) |
Problem
For a given model, it was required to further configure the pyspark job. We are adding config properties to do so.
Solution
In the
_submit_dataproc_job
method of theClusterDataprocHelper
we are reading optionaldataproc_pyspark_job
field. This field is an object with the following schema.Checklist