fix: cast dataproc batch runtime props

[jimmyshah]

resolves #1001

Problem

There is a bug currently that requires runtime_config properties values to be strings. As a result, integer values need quotes around them in the yml files, which is awkward.

With this PR, values are cast as strings, so that the properties can be set in a more expected way.

ADAP-1007

Solution

In _configure_batch(), I added a check for runtime_config.properties. If they exist, I iterate through the dictionary to cast the values as strings. Changing this part of the code was suggested as an option in #1001.

Checklist

• I have read the contributing guide and understand what's expected of me
• I have run this code in development and it appears to resolve the stated issue
• This PR includes tests, or tests are not required/relevant for this PR
• This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

[cla-bot]

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR.

CLA has not been signed by users: @jimmyshah

[cla-bot]

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR.

CLA has not been signed by users: @jimmyshah

[cla-bot]

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Jimmy Shah.
This is most likely caused by a git client misconfiguration; please make sure to:

1. check if your git client is configured with an email to sign commits git config --list | grep email
2. If not, set it up using git config --global user.email [email protected]
3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

[cla-bot]

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Jimmy Shah.
This is most likely caused by a git client misconfiguration; please make sure to:

1. check if your git client is configured with an email to sign commits git config --list | grep email
2. If not, set it up using git config --global user.email [email protected]
3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

[cla-bot]

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Jimmy Shah.
This is most likely caused by a git client misconfiguration; please make sure to:

1. check if your git client is configured with an email to sign commits git config --list | grep email
2. If not, set it up using git config --global user.email [email protected]
3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

[cla-bot]

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Jimmy Shah.
This is most likely caused by a git client misconfiguration; please make sure to:

1. check if your git client is configured with an email to sign commits git config --list | grep email
2. If not, set it up using git config --global user.email [email protected]
3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

[cla-bot]

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Jimmy Shah.
This is most likely caused by a git client misconfiguration; please make sure to:

1. check if your git client is configured with an email to sign commits git config --list | grep email
2. If not, set it up using git config --global user.email [email protected]
3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

[cla-bot]

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Jimmy Shah.
This is most likely caused by a git client misconfiguration; please make sure to:

1. check if your git client is configured with an email to sign commits git config --list | grep email
2. If not, set it up using git config --global user.email [email protected]
3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

[jimmyshah]

Hey @dbeatty10 @McKnight-42! Anything I can do to help move this PR forward?

Unrelated: I signed the CLA and have signed my git commits, but not sure why the cla-bot is disagreeing. Apologies for the mess...

[dbeatty10]

@cla-bot check

[cla-bot]

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Jimmy Shah.
This is most likely caused by a git client misconfiguration; please make sure to:

1. check if your git client is configured with an email to sign commits git config --list | grep email
2. If not, set it up using git config --global user.email [email protected]
3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

[cla-bot]

The cla-bot has been summoned, and re-checked this pull request!

[dbeatty10]

@jimmyshah

CLA

I signed the CLA and have signed my git commits, but not sure why the cla-bot is disagreeing. Apologies for the mess...

I'm guessing that the cla-bot is complaining about these two commits (a1f1608 and 3072f30):

Easiest path forward

My formatter/editor settings may have caused more changes than I intended, my apologies. I only meant to add these lines

If there is anything else I can do from my end, let me know!

The easiest thing at this point might be just to open a new PR. That way, all the commits would have the same identity that signed the CLA.

Also, if your PR adds only these lines, then you'll be more likely to pass our code-formatting checks too.

Alternative path forward

You could also try keeping this PR by:
`. undo all changes except for these lines

1. rebase all your commits and force-pushing

I'm guessing you'll find opening a new PR to be a bit easier, but either way works for us.

[jimmyshah]

Thanks for the suggestion @dbeatty10. I just opened a new PR #1024 and the issues seem to be resolved. I'll close the PR.