Skip to content

Commit

Permalink
initial work on bigquery canceling a retry if a job did in fact succe…
Browse files Browse the repository at this point in the history
…ed in previous run
  • Loading branch information
McKnight-42 committed Oct 23, 2023
1 parent a4e2b74 commit 6056dec
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions dbt/adapters/bigquery/connections.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
from functools import lru_cache
import agate
from requests.exceptions import ConnectionError
from typing import Optional, Any, Dict, List, Tuple
from typing import Optional, Any, Dict, Tuple

import google.auth
import google.auth.exceptions
Expand Down Expand Up @@ -287,7 +287,7 @@ def exception_handler(self, sql):
exc_message = exc_message.split(BQ_QUERY_JOB_SPLIT)[0].strip()
raise DbtRuntimeError(exc_message)

def cancel_open(self) -> List[str]:
def cancel_open(self) -> None:
names = []
this_connection = self.get_if_exists()
with self.lock:
Expand All @@ -308,7 +308,6 @@ def fn():

if connection.name is not None:
names.append(connection.name)
return names

@classmethod
def close(cls, connection):
Expand Down

0 comments on commit 6056dec

Please sign in to comment.