Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: increase iceberg retries in integration tests #746

Merged
merged 5 commits into from
Oct 28, 2024

Conversation

nicor88
Copy link
Contributor

@nicor88 nicor88 commented Oct 18, 2024

Description

The iceberg retries integration test is the most problematic. Sometimes, it passes, and sometimes, it does not.
Currently the test dues 10 parallel inserts. The idea of this PR is to increase num_iceberg_retries to a value big enough, to allow the test to pass.

Checklist

  • You followed contributing section
  • You kept your Pull Request small and focused on a single feature or bug fix.
  • You added unit testing when necessary
  • You added functional testing when necessary

@nicor88 nicor88 requested a review from a team as a code owner October 18, 2024 07:23
@nicor88
Copy link
Contributor Author

nicor88 commented Oct 18, 2024

@mikealfare @colin-rogers-dbt FYI.

@nicor88
Copy link
Contributor Author

nicor88 commented Oct 18, 2024

Input required and not supplied: aws-region

Integration tests seem to be failing because there is a missing region @mikealfare

I believe that the issue is because here, my user (and every other user that contribute) don't have access to the variable.
If the variable is set on your organization level, I cannot certenly use it. But if the variable is set on the repo level, I should be able to use it - as it used to be in the old dbt-athena repo.

@mikealfare
Copy link
Contributor

Input required and not supplied: aws-region

Integration tests seem to be failing because there is a missing region @mikealfare

I believe that the issue is because here, my user (and every other user that contribute) don't have access to the variable. If the variable is set on your organization level, I cannot certenly use it. But if the variable is set on the repo level, I should be able to use it - as it used to be in the old dbt-athena repo.

The region is there. This looks like it's related to the aws-creds action. It started failing for me after last night for v2, but v4 passes. I have another PR that was affectd that has that fix. So when I get that merged in, I'll sync this PR and all should be fine

@mikealfare mikealfare enabled auto-merge (squash) October 21, 2024 14:52
@nicor88
Copy link
Contributor Author

nicor88 commented Oct 23, 2024

@mikealfare any updates here? Integrations tests seems still not working, even after merging the latest from the main branch

@mikealfare mikealfare disabled auto-merge October 24, 2024 00:27
@mikealfare
Copy link
Contributor

Turning it off and on again

@mikealfare mikealfare enabled auto-merge (squash) October 28, 2024 21:19
@mikealfare mikealfare merged commit 3e6d043 into dbt-labs:main Oct 28, 2024
11 checks passed
@nicor88 nicor88 deleted the fix/improve_iceberg_retries_test branch October 29, 2024 08:45
@colin-rogers-dbt colin-rogers-dbt mentioned this pull request Dec 2, 2024
4 tasks
@colin-rogers-dbt colin-rogers-dbt mentioned this pull request Dec 9, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants