Fix Snapshot Merge Query #385
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in new record mode.
dbt/include/global_project/macros/materializations/snapshots/snapshot_merge.sql
Outdated
Show resolved
Hide resolved
adrianburusdbt
previously approved these changes
Dec 19, 2024
…d check to minimize any chance of regressions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Snowflake Bug Report: dbt-labs/dbt-snowflake#1275
BigQuery But Report: dbt-labs/dbt-snowflake#1275
Problem
The default merge query which implements snapshot logic was missing a filter for inserts, which caused it to miss inserting new records on delete.
Solution
Add a new filter for 'insert' records.
Checklist