Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapter tests for new snapshot configs #380

Merged
merged 5 commits into from
Dec 19, 2024
Merged

Adapter tests for new snapshot configs #380

merged 5 commits into from
Dec 19, 2024

Conversation

dbeatty10
Copy link
Contributor

@dbeatty10 dbeatty10 commented Dec 12, 2024 •
edited
Loading

resolves #

Problem

These tests in dbt-core can't be inherited by adapter maintainers: dbt-labs/dbt-core#10795

Solution

Add them to the dbt-adapters repo so they can be inherited by adapter maintainers.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development, and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX

@cla-bot cla-bot bot added the cla:yes label Dec 12, 2024
@VersusFacit VersusFacit marked this pull request as ready for review December 19, 2024 00:31
@VersusFacit VersusFacit requested a review from a team as a code owner December 19, 2024 00:31
VersusFacit
VersusFacit approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@VersusFacit VersusFacit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding these Doug!

@VersusFacit VersusFacit merged commit 911a60e into main Dec 19, 2024
32 checks passed
@VersusFacit VersusFacit deleted the dbeatty/test-snapshot-configs branch December 19, 2024 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VersusFacit VersusFacit VersusFacit approved these changes

Assignees
No one assigned
Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dbeatty10 @VersusFacit