Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support retryable exceptions during query execution #368

Merged
merged 13 commits into from
Dec 17, 2024
Merged

support retryable exceptions during query execution #368

merged 13 commits into from
Dec 17, 2024

Conversation

colin-rogers-dbt
Copy link
Contributor

@colin-rogers-dbt colin-rogers-dbt commented Dec 4, 2024 •
edited
Loading

  • support retryable exceptions during query execution

resolves #
docs dbt-labs/docs.getdbt.com/#

Problem

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development, and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX

@colin-rogers-dbt colin-rogers-dbt requested a review from a team as a code owner December 4, 2024 04:36
@cla-bot cla-bot bot added the cla:yes label Dec 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2024

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@colin-rogers-dbt colin-rogers-dbt marked this pull request as draft December 4, 2024 04:40
@colin-rogers-dbt colin-rogers-dbt mentioned this pull request Dec 4, 2024
Merged
4 tasks
@VersusFacit VersusFacit self-assigned this Dec 5, 2024
@VersusFacit VersusFacit marked this pull request as ready for review December 5, 2024 02:58
mikealfare
mikealfare reviewed Dec 5, 2024
View reviewed changes
Copy link
Contributor

@mikealfare mikealfare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few style nits and one actual blocking change (the double decrement for retries).

dbt/adapters/sql/connections.py Outdated Show resolved Hide resolved
dbt/adapters/sql/connections.py Outdated Show resolved Hide resolved
dbt/adapters/sql/connections.py Outdated Show resolved Hide resolved
dbt/adapters/sql/connections.py Outdated Show resolved Hide resolved
dbt/adapters/sql/connections.py Outdated Show resolved Hide resolved
mikealfare
mikealfare previously approved these changes Dec 17, 2024
View reviewed changes
@mikealfare mikealfare dismissed their stale review December 17, 2024 00:44

I missed the signature change.

mikealfare
mikealfare previously approved these changes Dec 17, 2024
View reviewed changes
@colin-rogers-dbt colin-rogers-dbt merged commit a8f34ae into main Dec 17, 2024
32 checks passed
@colin-rogers-dbt colin-rogers-dbt deleted the addQueryRetries branch December 17, 2024 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VersusFacit VersusFacit VersusFacit left review comments

@mikealfare mikealfare mikealfare approved these changes

Assignees

@VersusFacit VersusFacit

Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@colin-rogers-dbt @mikealfare @VersusFacit