Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] README is mis-titled #255

Closed
wants to merge 3 commits into from
Closed

[docs] README is mis-titled #255

wants to merge 3 commits into from

Conversation

farmanp
Copy link

@farmanp farmanp commented Jul 1, 2024

resolves: #233
related: dbt-labs/dbt-core#10384

Problem

Header name was incorrect

Solution

Correct it from dbt-test-adapter to dbt-adapters

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development, and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX

@farmanp farmanp requested a review from a team as a code owner July 1, 2024 04:48
Copy link

cla-bot bot commented Jul 1, 2024

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR.

CLA has not been signed by users: @farmanp

@farmanp farmanp changed the title [farmanp/dbt-adapters] - Update README.md for DBT Adapters [docs][farmanp/dbt-adapters] - Update README.md for DBT Adapters Jul 1, 2024
@dataders dataders added the paper_cut A small change that impacts lots of users in their day-to-day label Jul 1, 2024
@dataders dataders changed the title [docs][farmanp/dbt-adapters] - Update README.md for DBT Adapters [docs] README is mis-titled Jul 1, 2024
Copy link

cla-bot bot commented Jul 1, 2024

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR.

CLA has not been signed by users: @servis

Copy link

cla-bot bot commented Nov 20, 2024

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR.

CLA has not been signed by users: @servis

@amychen1776
Copy link
Contributor

closing this since we did fix it in another PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paper_cut A small change that impacts lots of users in their day-to-day
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] improve repo's top-level README.md
3 participants