Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

download archive to the expected directory #142

Merged
merged 6 commits into from
Apr 2, 2024

Conversation

mikealfare
Copy link
Contributor

@mikealfare mikealfare commented Apr 1, 2024

Problem

We downloaded the archive to the working directory, but we expect that the artifacts are in ./dist/.

Solution

Update the download step to reference ./dist/

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development, and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX

@mikealfare
Copy link
Contributor Author

The failed workflows are due to the package already being published on PyPI. This is expected. This version of the workflow successfully published to GH.

@mikealfare mikealfare requested a review from a team April 2, 2024 00:01
@mikealfare mikealfare merged commit 8cddfd3 into main Apr 2, 2024
10 checks passed
@mikealfare mikealfare deleted the config/fix-github-release branch April 2, 2024 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants