Skip to content

Commit

Permalink
Remove test classes in favor of inheritance within concrete adapters
Browse files Browse the repository at this point in the history
  • Loading branch information
dbeatty10 committed Dec 12, 2024
1 parent e12a3d4 commit ab1ba01
Showing 1 changed file with 0 additions and 20 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -65,10 +65,6 @@ def test_snapshot_column_names(self, project):
check_relations_equal(project.adapter, ["snapshot_actual", "snapshot_expected"])


class TestSnapshotColumnNames(BaseSnapshotColumnNames):
pass


class BaseSnapshotColumnNamesFromDbtProject:
@pytest.fixture(scope="class")
def snapshots(self):
Expand Down Expand Up @@ -114,10 +110,6 @@ def test_snapshot_column_names_from_project(self, project):
check_relations_equal(project.adapter, ["snapshot_actual", "snapshot_expected"])


class TestSnapshotColumnNamesFromDbtProject(BaseSnapshotColumnNamesFromDbtProject):
pass


class BaseSnapshotInvalidColumnNames:
@pytest.fixture(scope="class")
def snapshots(self):
Expand Down Expand Up @@ -184,10 +176,6 @@ def test_snapshot_invalid_column_names(self, project):
assert "Snapshot target is missing configured columns" in log_output


class TestSnapshotInvalidColumnNames(BaseSnapshotInvalidColumnNames):
pass


class BaseSnapshotDbtValidToCurrent:
@pytest.fixture(scope="class")
def snapshots(self):
Expand Down Expand Up @@ -237,10 +225,6 @@ def test_valid_to_current(self, project):
check_relations_equal(project.adapter, ["snapshot_actual", "snapshot_expected"])


class TestSnapshotDbtValidToCurrent(BaseSnapshotDbtValidToCurrent):
pass


# This uses snapshot_meta_column_names, yaml-only snapshot def,
# and multiple keys
class BaseSnapshotMultiUniqueKey:
Expand Down Expand Up @@ -268,7 +252,3 @@ def test_multi_column_unique_key(self, project):
assert len(results) == 1

check_relations_equal(project.adapter, ["snapshot_actual", "snapshot_expected"])


class TestSnapshotMultiUniqueKey(BaseSnapshotMultiUniqueKey):
pass

0 comments on commit ab1ba01

Please sign in to comment.