-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use 1.15 + cleanup #156
Use 1.15 + cleanup #156
Conversation
|
||
import { TestingRuntime, createTestingRuntime } from '@dbos-inc/dbos-sdk'; | ||
|
||
export { Operations } from './YKYOperations'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately the test runtime doesn't open dbos-config.yaml and read the entrypoints .js files, so I had to mention the name of one of the operations files from the test... otherwise nothing gets loaded. Will put fixing on the TODO list for next week.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it fixed by our latest release v1.15?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will check. I did find an issue with the widget store also. Time to dust off this PR (which somehow I forgot about).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a long story about how I was not able to read the entrypoints from the .yaml file.
Because of when testRuntime is created in most tests, you have to set "NODE_OPTIONS=--experimental-vm-modules" which is... eww. And once you've done that, if you create the test runtime more than once a different set of bad things happens. So it was better to not do anything / more research is needed.
Use 1.15.9
Allows some exports and [classlist]s to be removed.