Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 1.15 + cleanup #156

Merged
merged 5 commits into from
Jun 26, 2024
Merged

Use 1.15 + cleanup #156

merged 5 commits into from
Jun 26, 2024

Conversation

chuck-dbos
Copy link
Collaborator

@chuck-dbos chuck-dbos commented Jun 19, 2024

Use 1.15.9
Allows some exports and [classlist]s to be removed.


import { TestingRuntime, createTestingRuntime } from '@dbos-inc/dbos-sdk';

export { Operations } from './YKYOperations';
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately the test runtime doesn't open dbos-config.yaml and read the entrypoints .js files, so I had to mention the name of one of the operations files from the test... otherwise nothing gets loaded. Will put fixing on the TODO list for next week.

Copy link
Member

@qianl15 qianl15 Jun 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it fixed by our latest release v1.15?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will check. I did find an issue with the widget store also. Time to dust off this PR (which somehow I forgot about).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was a long story about how I was not able to read the entrypoints from the .yaml file.
Because of when testRuntime is created in most tests, you have to set "NODE_OPTIONS=--experimental-vm-modules" which is... eww. And once you've done that, if you create the test runtime more than once a different set of bad things happens. So it was better to not do anything / more research is needed.

@chuck-dbos chuck-dbos marked this pull request as ready for review June 19, 2024 19:24
@chuck-dbos chuck-dbos marked this pull request as draft June 25, 2024 23:30
@chuck-dbos chuck-dbos changed the title Use 1.14 + cleanup Use 1.15 + cleanup Jun 26, 2024
@chuck-dbos chuck-dbos marked this pull request as ready for review June 26, 2024 01:11
@chuck-dbos chuck-dbos merged commit 4aa05a5 into main Jun 26, 2024
7 checks passed
@chuck-dbos chuck-dbos deleted the chuck/use14 branch June 26, 2024 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants