Add notes for Case items #737
Conversation
- feat: note icon functionality - style: use flexbox container to align indicators
- style: add classnames
- feat: consider empty string notes as non-notes
- fix: remove line appearing at bottom of element
- feat: pass down result to component - feat: POST and PATCH funcitonality
- feat: update date and user after request
- feat: add loading spinner to save button
- feat: switch to status based note deletion
- feat: note icon functionality - style: use flexbox container to align indicators
- style: add classnames
…portal into cfm-dash_comments
- feat: add latency warning on save
- style: render hidden note icon (icon added after component load) - feat: update note icon on input text change
- feat: update status indicator tooltip on unsaved changes
There was a problem hiding this comment.
Nice job on this! Most of the comments on here are smaller nitpicks and things that probably don't need to be explicitly addressed before merging, but there are some things in CaseNotesColumn that I'd like changed before approval. It should be fairly clear which is which, but if it isn't, please don't hesitate to ask!
- feat: update warning text - feat: keep warning text in variable - feat: remove status indicator response to save state
- feat: add and format error text in UI
There was a problem hiding this comment.
One small comment to address; otherwise, tested well (no front-end code review from me). I found the lack of an explicit delete note button a little odd but figured out I could do it by saving with no text; can't remember what we do with technical review here.
- chore: bump minor version (semver)
- fix: remove default ull value for nonexistent notes
Hmm, yeah that's fair. Can bring that up for the future. |
Corresponds to Trello Ticket
deployed to cgap-devtest 09/25