Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Facet Terms Grouping (Port from FF) #718

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

utku-ozturk
Copy link
Contributor

@utku-ozturk utku-ozturk commented May 16, 2023

Trello: https://trello.com/c/nwosFKMo

Please also refer to:

The update allows for a hierarchical display of terms grouped under a grouping term. It also enables searching and selection by group names and individual terms.

You must add the group_by_field property in schema json to define grouping for a facet.

(the code block and screenshot below are only for examples, not actually pushed into repo)

    "facets": {
        "file_type": {
            "title": "File Type",
            "descripton": "Type or categorization of this file.",
            "group_by_field": "file_classification"
        },
        ...
Screen Shot 2023-05-17 at 01 17 08

Copy link
Member

@Bianca-Morris Bianca-Morris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this; looks good. Tested this on local in a bunch of Item search pages and a few embedded search tables; seems like the changes aren't causing any issues (as expected). I'd wait until @willronchetti has an opportunity to double check the search edits to merge this, though. Maybe reach out to him directly; it's possible it's slipped by him.

@utku-ozturk
Copy link
Contributor Author

utku-ozturk commented Jun 2, 2023

@Bianca-Morris Thanks for the review. By the way, we have an ongoing update that we already had applied for FF, and we will push the commit into CGAP shortly after the tests end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants