Upgrade cgap-portal to pytest 7.2 (C4-183) #687
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
netsettler
commented
Jan 31, 2023
•
netsettler
commented
- Backport pytest 7.2 support from Fourfront
- Move to poetry 1.3.2
- Remove dependence in a pinned version of setuptools
…est-2.9.2-broken-by-4.5-upgrade
…essary to re-make the lock file.
…to run without instafail.
…d and local_collections.
…otes in comments. No real functional change.
…ther than session-scoped.
…ng in src/encoded/tests/test_create_mapping.py.
…of tests into variables so that they are shared in ways that are easier to understand.
netsettler
changed the title
pyproject.toml
Outdated
| jmespath = "0.9.0" | ||
| jsonschema_serialize_fork = "^2.1.1" | ||
| keepalive = "0.5" | ||
| # keepalive = "0.5" |
There was a problem hiding this comment.
I guess we like to delete these entirely rather than keeping commented out?
There was a problem hiding this comment.
Yeah, when I'm sometimes turning things on and off, I leave them for a while and delete them later, but I think this can reasonably go away before I merge.
dmichaels-harvard
approved these changes
Mar 14, 2023
willronchetti
approved these changes
Mar 14, 2023
| @@ -180,8 +162,11 @@ def test_create_mapping_on_indexing(app, setup_and_teardown, testapp, registry, | |||
| assert compare_against_existing_mapping(es, namespaced_index, item_type, item_record, True) | |||
|
|
|||
|
|
|||
| @pytest.mark.flaky | |||
| def test_file_processed_detailed(app, setup_and_teardown, testapp, indexer_testapp, project, institution, file_formats): | |||
| @pytest.mark.broken # Doesn't work on GitHub Actions | |||
There was a problem hiding this comment.
Can we look into this further? What error is occurring?
There was a problem hiding this comment.
I'll look at that, yes.
netsettler
changed the title
netsettler
added
the
salvage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.