Skip to content

Commit

Permalink
Merge pull request #746 from dbmi-bgm/bm-node18-upgrade
Browse files Browse the repository at this point in the history
Bm node18 upgrade
  • Loading branch information
Bianca-Morris authored Sep 11, 2023
2 parents 370022e + a4606b6 commit b9e242c
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 4 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:
test_type: ['UNIT', 'INDEX', 'DOCKER']
# We are really not set up for these next two to be multiplicative, so be careful adding more.
python_version: ['3.8']
node_version: ['16']
node_version: ['18']

# Steps represent a sequence of tasks that will be executed as part of the job
steps:
Expand Down Expand Up @@ -108,7 +108,7 @@ jobs:
poetry run wipe-test-indices $TEST_JOB_ID search-cgap-unit-testing-opensearch-tcs45cjpwgdzoi7pafr6oewq6u.us-east-1.es.amazonaws.com:443
- name: Docker Build
if: ${{ matrix.test_type == 'DOCKER' && matrix.node_version == '16' && matrix.python_version == '3.8' }}
if: ${{ matrix.test_type == 'DOCKER' && matrix.node_version == '18' && matrix.python_version == '3.8' }}
run: |
touch deploy/docker/local/docker_development.ini # cheap substitute for prepare-docker to make ignored file
docker build .
8 changes: 8 additions & 0 deletions CHANGELOG.rst
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,14 @@ cgap-portal
Change Log
----------

14.3.0
======
`PR 746: Bm node18 upgrade <https://github.com/dbmi-bgm/cgap-portal/pull/746>`_

* Update Docker's MakeFile to use Node version 18.17.0
* Update Github workflows to use Node version 18.17.0


14.2.3
======

Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ ENV NGINX_USER=nginx \
PIP_DISABLE_PIP_VERSION_CHECK=on \
PIP_DEFAULT_TIMEOUT=100 \
NVM_VERSION=v0.39.1 \
NODE_VERSION=16.14.0
NODE_VERSION=18.17.0

# Configure Python3.7 venv
ENV VIRTUAL_ENV=/opt/venv
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
[tool.poetry]
# Note: Various modules refer to this system as "encoded", not "cgap-portal".
name = "encoded"
version = "14.2.3"
version = "14.3.0"
description = "Computational Genome Analysis Platform"
authors = ["4DN-DCIC Team <[email protected]>"]
license = "MIT"
Expand Down

0 comments on commit b9e242c

Please sign in to comment.