Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates #7

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Updates #7

wants to merge 7 commits into from

Conversation

dmaziec
Copy link
Member

@dmaziec dmaziec commented Aug 4, 2023

  • adjust variable names to the data model
  • adjust the format of putative drivers to make it compatible with the browser
  • fix dockerfile for ASCAT

B3rse
B3rse approved these changes Aug 7, 2023
View reviewed changes
descriptions/ascat.cwl
type: File
inputBinding:
prefix: "--tumor_file"
prefix: "--input_tumor_bam"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this expected to be changed right? just checking is not a unintended search and replace results

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it is looking at the rest of the code, but just to double check I am leaving this comment here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, these variable names match the expected variable names to create metaworkflows runs through magma

descriptions/ascat.cwl
type: File
inputBinding:
prefix: "--normal_file"
prefix: "--input_normal_bam"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@B3rse B3rse B3rse approved these changes

@dominikglodzikhms dominikglodzikhms Awaiting requested review from dominikglodzikhms

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmaziec @B3rse