Fix bad total snippets counts. #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbaiter
force-pushed
the
fix-wrong-totalcount
branch
from
f49c919 to
e0c4720
Compare
schmika
reviewed
May 29, 2024
jbaiter
force-pushed
the
fix-wrong-totalcount
branch
from
e0c4720 to
6c14c34
Compare
schmika
previously approved these changes
Jun 3, 2024
Turns out we were mixing up the counts between multiple documents by keying according to the leaf-reader-relativ docId instead of the index-absolute docId. This led to differing total counts between different runs of one and the same query, which is how this was discovered. Total counts should be accurate now.
jbaiter
force-pushed
the
fix-wrong-totalcount
branch
from
6c14c34 to
63e3ca4
Compare
schmika
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out we were mixing up the counts between multiple documents by keying according to the leaf-reader-relativ docId instead of the index-absolute docId. This led to differing total counts between different runs of one and the same query, which is how this was discovered. Total counts should be accurate now.