Fix regular highlighting in case no hl field can be determined (fixes #396) #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…396) Looks like there's a bug in Solr where when no highlighting field can be determined (from `hl.fl` or the `df` defined for the query parser), the set of highlight fields will contain a single `null` value that triggers an exception down the line, causing the highlight component to fail and the response to return with a 400 error code. The workaround is to simply set the `hl.fl` paremter for the regular highlighter explicitly, and excluding the `null` value there.
schmika
approved these changes
Mar 5, 2024
jbaiter
added a commit
that referenced
this pull request
Apr 25, 2024
**Changed:** - Missing files no longer fail the complete search request, instead the OCR highlighting for the document is skipped - Add support for Solr 9.5 - Updated documentation with warning for Solr 9 users to disable security sandboxing when using pointers to external files **Fixed:** - Regular highlighting in case no hl field can be determined works again (#404) - Passage building across more than two concatenated files works now (#422)
Merged
jbaiter
added a commit
that referenced
this pull request
Apr 25, 2024
**Changed:** - Missing files no longer fail the complete search request, instead the OCR highlighting for the document is skipped - Add support for Solr 9.5 - Updated documentation with warning for Solr 9 users to disable security sandboxing when using pointers to external files **Fixed:** - Regular highlighting in case no hl field can be determined works again (#404) - Passage building across more than two concatenated files works now (#422)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like there's a bug in Solr where when no highlighting field can be determined (from
hl.flor thedfdefined for the query parser), the set of highlight fields will contain a singlenullvalue that triggers an exception down the line, causing the highlight component to fail and the response to return with a 400 error code.The workaround is to simply set the
hl.flparemter for the regular highlighter explicitly, and excluding thenullvalue there.