Merge pull request #124 from dbmdz/manifestations-performance

Manifestations performance
dbmdz · Jun 7, 2024 · 4b0a996 · 4b0a996
2 parents 15b7bcb + 37c6551
commit 4b0a996
Show file tree

Hide file tree

Showing 14 changed files with 23 additions and 19 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -6,6 +6,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
 
 ## Unreleased
 
+### Fixed
+
+- Increased performance of reflection by 32.8%
+
 ## [9.2.0](https://github.com/dbmdz/metadata-service/releases/tag/9.2.0) - 2024-06-03
 
 ### Added

diff --git a/metasvc-client/pom.xml b/metasvc-client/pom.xml
@@ -6,7 +6,7 @@
   <parent>
     <groupId>io.github.dbmdz.metadata</groupId>
     <artifactId>metasvc</artifactId>
-    <version>9.2.0</version>
+    <version>9.2.1-SNAPSHOT</version>
   </parent>
 
   <name>Metadata-Service: Repository Client</name>

diff --git a/metasvc-lobid-client/pom.xml b/metasvc-lobid-client/pom.xml
@@ -7,7 +7,7 @@
   <parent>
     <groupId>io.github.dbmdz.metadata</groupId>
     <artifactId>metasvc</artifactId>
-    <version>9.2.0</version>
+    <version>9.2.1-SNAPSHOT</version>
   </parent>
 
   <name>Metadata-Service: lobid.org Client</name>

diff --git a/metasvc-model/pom.xml b/metasvc-model/pom.xml
@@ -6,7 +6,7 @@
   <parent>
     <groupId>io.github.dbmdz.metadata</groupId>
     <artifactId>metasvc</artifactId>
-    <version>9.2.0</version>
+    <version>9.2.1-SNAPSHOT</version>
   </parent>
 
   <name>Metadata-Service: Model</name>

diff --git a/...rc/main/java/de/digitalcollections/model/identifiable/DerivedIdentifiableBuildHelper.java b/...rc/main/java/de/digitalcollections/model/identifiable/DerivedIdentifiableBuildHelper.java
@@ -4,6 +4,7 @@
 import java.lang.reflect.Method;
 import java.lang.reflect.Type;
 import java.util.List;
+import java.util.Optional;
 import java.util.stream.Collectors;
 import java.util.stream.Stream;
 import org.slf4j.Logger;
@@ -41,22 +42,21 @@ public static <D extends Identifiable> D build(Identifiable identifiable, Class<
         if (!identifiableGetter.getName().startsWith("get")) continue;
         Type returnType = identifiableGetter.getGenericReturnType();
         // ...find the corresponding setter of the new object...
-        Method[] setters =
+        String searchedSetter = "set" + identifiableGetter.getName().substring(3);
+        Optional<Method> setter =
             derivedInstSetters.stream()
                 .filter(
                     derivSetter ->
-                        derivSetter
-                                .getName()
-                                .equals(identifiableGetter.getName().replaceFirst("^get", "set"))
+                        derivSetter.getName().equals(searchedSetter)
                             && derivSetter.getParameterCount() == 1
                             && derivSetter
                                 .getParameters()[0]
                                 .getParameterizedType()
                                 .equals(returnType))
-                .toArray(i -> new Method[i]);
-        if (setters.length != 1) continue;
+                .findFirst();
+        if (setter.isEmpty()) continue;
         // ...and invoke this setter with the getter's returned value
-        setters[0].invoke(derivedInst, identifiableGetter.invoke(identifiable));
+        setter.get().invoke(derivedInst, identifiableGetter.invoke(identifiable));
       }
       return derivedInst;
     } catch (InstantiationException

diff --git a/metasvc-server/backend-api/pom.xml b/metasvc-server/backend-api/pom.xml
@@ -6,7 +6,7 @@
   <parent>
     <groupId>io.github.dbmdz.metadata</groupId>
     <artifactId>metasvc-server</artifactId>
-    <version>9.2.0</version>
+    <version>9.2.1-SNAPSHOT</version>
   </parent>
 
   <name>Metadata-Service: Repository Server (Backend API)</name>

diff --git a/metasvc-server/backend-file/pom.xml b/metasvc-server/backend-file/pom.xml
@@ -5,7 +5,7 @@
   <parent>
     <groupId>io.github.dbmdz.metadata</groupId>
     <artifactId>metasvc-server</artifactId>
-    <version>9.2.0</version>
+    <version>9.2.1-SNAPSHOT</version>
   </parent>
 
   <name>Metadata-Service: Repository Server (Backend IMPL File)</name>

diff --git a/metasvc-server/backend-inmemory/pom.xml b/metasvc-server/backend-inmemory/pom.xml
@@ -6,7 +6,7 @@
   <parent>
     <groupId>io.github.dbmdz.metadata</groupId>
     <artifactId>metasvc-server</artifactId>
-    <version>9.2.0</version>
+    <version>9.2.1-SNAPSHOT</version>
   </parent>
 
   <name>Metadata-Service: Repository Server (Backend IMPL InMemory)</name>

diff --git a/metasvc-server/backend-jdbi/pom.xml b/metasvc-server/backend-jdbi/pom.xml
@@ -8,7 +8,7 @@
   <parent>
     <groupId>io.github.dbmdz.metadata</groupId>
     <artifactId>metasvc-server</artifactId>
-    <version>9.2.0</version>
+    <version>9.2.1-SNAPSHOT</version>
   </parent>
 
   <name>Metadata-Service: Repository Server (Backend IMPL JDBI PostgreSql)</name>

diff --git a/metasvc-server/backend-lobid/pom.xml b/metasvc-server/backend-lobid/pom.xml
@@ -6,7 +6,7 @@
   <parent>
     <groupId>io.github.dbmdz.metadata</groupId>
     <artifactId>metasvc-server</artifactId>
-    <version>9.2.0</version>
+    <version>9.2.1-SNAPSHOT</version>
   </parent>
 
   <name>Metadata-Service: Repository Server (Backend IMPL External System lobid.org)</name>

diff --git a/metasvc-server/business/pom.xml b/metasvc-server/business/pom.xml
@@ -6,7 +6,7 @@
   <parent>
     <groupId>io.github.dbmdz.metadata</groupId>
     <artifactId>metasvc-server</artifactId>
-    <version>9.2.0</version>
+    <version>9.2.1-SNAPSHOT</version>
   </parent>
 
   <name>Metadata-Service: Repository Server (Business)</name>

diff --git a/metasvc-server/pom.xml b/metasvc-server/pom.xml
@@ -6,7 +6,7 @@
   <parent>
     <groupId>io.github.dbmdz.metadata</groupId>
     <artifactId>metasvc</artifactId>
-    <version>9.2.0</version>
+    <version>9.2.1-SNAPSHOT</version>
   </parent>
 
   <name>Metadata-Service: Repository Server</name>

diff --git a/metasvc-server/webapp/pom.xml b/metasvc-server/webapp/pom.xml
@@ -6,7 +6,7 @@
   <parent>
     <groupId>io.github.dbmdz.metadata</groupId>
     <artifactId>metasvc-server</artifactId>
-    <version>9.2.0</version>
+    <version>9.2.1-SNAPSHOT</version>
   </parent>
 
   <name>Metadata-Service: Repository Server (Webapp)</name>

diff --git a/pom.xml b/pom.xml
@@ -11,7 +11,7 @@
 
   <groupId>io.github.dbmdz.metadata</groupId>
   <artifactId>metasvc</artifactId>
-  <version>9.2.0</version>
+  <version>9.2.1-SNAPSHOT</version>
   <packaging>pom</packaging>
 
   <name>Metadata-Service</name>