Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cb 5988 plugin template #3136

Open
wants to merge 2 commits into
base: devel
Choose a base branch
from
Open

Cb 5988 plugin template #3136

wants to merge 2 commits into from

Conversation

devnaumov
Copy link
Member

No description provided.

@devnaumov devnaumov requested review from Wroud and sergeyteleshev and removed request for Wroud December 13, 2024 15:42
@devnaumov devnaumov marked this pull request as ready for review December 13, 2024 15:42
const opts = body && body.length > 0 ? { input: body } : {};
return require('execa').command(action, { ...opts, shell: true });
},
createPrompter: () => require('enquirer'),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add enquirer dependency to the package.json

Comment on lines +12 to +14
{
"path": "../core-di/tsconfig.json"
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will not work in ee

Comment on lines +24 to +26
"dependencies": {
"@cloudbeaver/core-di": "^0",
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should have core-cli and typescript dev dependencies

---
import type { PluginManifest } from '@cloudbeaver/core-di';

export const <%= h.changeCase.camel(name) %>: PluginManifest = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add Manifest suffix

import { Bootstrap, injectable } from '@cloudbeaver/core-di';

@injectable()
export class <%= h.changeCase.pascal(name) %>Service extends Bootstrap {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use Bootstrap suffix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants