-
Notifications
You must be signed in to change notification settings - Fork 392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CB-6000 handle task info events from WS #3132
Merged
SychevAndrey
merged 15 commits into
CB-3508-te-initiate-events-for-execute-query-and-all-async-tasks
from
CB-6000-handle-task-info-events
Dec 13, 2024
Merged
CB-6000 handle task info events from WS #3132
SychevAndrey
merged 15 commits into
CB-3508-te-initiate-events-for-execute-query-and-all-async-tasks
from
CB-6000-handle-task-info-events
Dec 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SychevAndrey
requested review from
Wroud,
sergeyteleshev,
devnaumov and
yagudin10
December 12, 2024 09:49
Wroud
requested changes
Dec 12, 2024
webapp/packages/core-root/src/AsyncTask/AsyncTaskInfoService.ts
Outdated
Show resolved
Hide resolved
return back task id generation and saving on creation. Added second map filled on running and linking backend Id and frontend Id. Added helper method to get task
add pending events map to save last status if it's came earlier than we saved the task
…ync-tasks' into CB-6000-handle-task-info-events
Wroud
requested changes
Dec 13, 2024
webapp/packages/core-root/src/AsyncTask/AsyncTaskInfoService.ts
Outdated
Show resolved
Hide resolved
webapp/packages/core-root/src/AsyncTask/AsyncTaskInfoService.ts
Outdated
Show resolved
Hide resolved
Wroud
approved these changes
Dec 13, 2024
SychevAndrey
merged commit Dec 13, 2024
acd3fe2
into
CB-3508-te-initiate-events-for-execute-query-and-all-async-tasks
2 of 6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AsyncTaskService
was moved to core-root to avoid circular dependenciesAsyncTask.create
)updateStatus
method was added to update task status on websocket message if task is runningrunning
prop is changing tofalse
, we request gql endpoint