Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CB-6000 handle task info events from WS #3132

Conversation

SychevAndrey
Copy link
Contributor

  1. AsyncTaskService was moved to core-root to avoid circular dependencies
  2. Task is added to tasks map only when getter brings data from backend to save real task ID (AsyncTask.create)
  3. updateStatus method was added to update task status on websocket message if task is running
  4. When running prop is changing to false, we request gql endpoint
  5. Naming improvements (onEvent return type Subscription -> Unsubscribe) to avoid confusion with Rx Subscription plus it's basically returns cancel function, not subscription in any sense.

return back task id generation and saving on creation. Added second map filled on running and linking backend Id and frontend Id. Added helper method to get task
add pending events map to save last status if it's came earlier than we saved the task
@SychevAndrey SychevAndrey requested a review from Wroud December 12, 2024 17:01
@SychevAndrey SychevAndrey requested a review from Wroud December 13, 2024 09:56
@SychevAndrey SychevAndrey merged commit acd3fe2 into CB-3508-te-initiate-events-for-execute-query-and-all-async-tasks Dec 13, 2024
2 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants