CB-5891 User - error after disabling and deleting #3056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wroud
requested changes
Nov 7, 2024
Comment on lines
62
to
64
| function onDisableUser() { | ||
| userFormInfoPart.state.enabled = false; | ||
| } |
There was a problem hiding this comment.
seems like we need to create disable method in the form part and use it to disable user and sync form:
(pseudocode)
this.state.enabled = false;
await this.save()
Wroud
requested changes
Nov 7, 2024
| @@ -74,6 +74,11 @@ export class UserFormInfoPart extends FormPart<IUserFormInfoState, IUserFormStat | |||
| return this.loaded; | |||
| } | |||
|
|
|||
| async disableUser() { | |||
| this.state.enabled = false; | |||
| await this.saveChanges(); | |||
There was a problem hiding this comment.
You need to call save to handle update and error handling logic (for example, if the user made some changes that will not pass validation, calling saveChanges directly will skip this logic, and it also will make it possible to run multiple concurrent save requests to the backend
devnaumov
approved these changes
Nov 8, 2024
Wroud
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.