Cb 5368 create api for kill session sm #3028
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wroud
requested changes
Oct 24, 2024
| onRootMenuOpen: IExecutor<IDataGridCellMenuContext>; | ||
| static cellContext = 'data-grid-cell-context-menu'; | ||
| private static readonly menuToken = 'dataGridCell'; | ||
| export class DataViewerContextMenuService { |
There was a problem hiding this comment.
we really don't want to move this service outside of plugin-data-viewer because it's too wired with data presentation and not abstract from data model we also need to rewrite it to our new context menu api. I suggest to use bottom bar instead to avoid this changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.