Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CB-5205 fix: connection view switching #2984

Merged
merged 9 commits into from
Oct 15, 2024
Merged

Conversation

Wroud
Copy link
Member

@Wroud Wroud commented Oct 9, 2024

No description provided.

@Wroud Wroud self-assigned this Oct 9, 2024
@@ -46,7 +46,9 @@ export const AppStateMenu = observer(function AppStateMenu() {
return (
<SContext registry={registry}>
<div className={s(styles, { menuWrapper: true, appStateMenu: true })}>
<MenuBar menu={menu} nestedMenuSettings={{ modal: true }} />
<Loader className={s(styles, { loader: true }, 'secondary')} secondary suspense small inline>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we duplicate secondary as class and secondary as prop here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cuz it can be another loader in MenuBar to display is also as secondary

@Wroud Wroud merged commit 67c54d2 into devel Oct 15, 2024
7 checks passed
@Wroud Wroud deleted the fix/cb-5205/connection-sync branch October 15, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants