-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CB-5052 [2562 FR] Highlight the row where any field is currently selected #2952
Merged
Wroud
merged 19 commits into
devel
from
CB-5052-2562-fr-highlight-the-row-where-any-field-is-currently-selected
Oct 8, 2024
Merged
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
5c20e4a
CB-5052-2562 adds background for selected row
sergeyteleshev acf7cc0
CB-5052-2562 fixes background for selected row
sergeyteleshev 8bd1469
CB-5052-2562 moves style var
sergeyteleshev 7e720da
Merge branch 'devel' into CB-5052-2562-fr-highlight-the-row-where-any…
Wroud b00da34
CB-5052 pr fixes
sergeyteleshev 56f5c82
CB-5052 fixes color for selection
sergeyteleshev b7597d7
CB-5052 fixes color for selection 2
sergeyteleshev 5b18ed8
Merge branch 'devel' into CB-5052-2562-fr-highlight-the-row-where-any…
dariamarutkina b5d6440
Merge branch 'devel' into CB-5052-2562-fr-highlight-the-row-where-any…
dariamarutkina 6567876
CB-5052 adds themes and fixes actions styles for focused cursor in table
sergeyteleshev 02f96a6
CB-5052 reverts theme for data grid. plus replaces selected row style
sergeyteleshev 8511fd5
CB-5052 cleanup
sergeyteleshev edc8719
CB-5052 cleanup
sergeyteleshev 2c1bb22
CB-5052 makes selected tab blue
sergeyteleshev 58f1365
CB-5052 reverts refresh button colors
sergeyteleshev 6183a2f
Merge branch 'devel' into CB-5052-2562-fr-highlight-the-row-where-any…
dariamarutkina 7e58c1b
CB-5052 fixes unneeded border left
sergeyteleshev e73d9eb
Merge branch 'devel' into CB-5052-2562-fr-highlight-the-row-where-any…
dariamarutkina 4bc034d
Merge branch 'devel' into CB-5052-2562-fr-highlight-the-row-where-any…
Wroud File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 changes: 13 additions & 0 deletions
13
webapp/packages/plugin-data-spreadsheet-new/src/theme/dark.module.scss
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
/* | ||
* CloudBeaver - Cloud Database Manager | ||
* Copyright (C) 2020-2024 DBeaver Corp and others | ||
* | ||
* Licensed under the Apache License, Version 2.0. | ||
* you may not use this file except in compliance with the License. | ||
*/ | ||
|
||
@import '@cloudbeaver/core-theming/src/styles/theme-dark'; | ||
|
||
:global .#{$theme-class} { | ||
--data-grid-index-color: #32475e; | ||
} |
12 changes: 12 additions & 0 deletions
12
webapp/packages/plugin-data-spreadsheet-new/src/theme/light.module.scss
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
/* | ||
* CloudBeaver - Cloud Database Manager | ||
* Copyright (C) 2020-2024 DBeaver Corp and others | ||
* | ||
* Licensed under the Apache License, Version 2.0. | ||
* you may not use this file except in compliance with the License. | ||
*/ | ||
@import '@cloudbeaver/core-theming/src/styles/theme-light'; | ||
|
||
:global .#{$theme-class} { | ||
--data-grid-index-color: #c2d8ee; | ||
} |
28 changes: 28 additions & 0 deletions
28
webapp/packages/plugin-data-spreadsheet-new/src/theme/styles.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
/* | ||
* CloudBeaver - Cloud Database Manager | ||
* Copyright (C) 2020-2024 DBeaver Corp and others | ||
* | ||
* Licensed under the Apache License, Version 2.0. | ||
* you may not use this file except in compliance with the License. | ||
*/ | ||
import type { ThemeSelector } from '@cloudbeaver/core-theming'; | ||
|
||
import type Dark from './dark.module.scss'; | ||
import type Light from './light.module.scss'; | ||
|
||
export const DATA_GRID_BASE_STYLES: ThemeSelector = async theme => { | ||
let styles: typeof Light & typeof Dark; | ||
const dark = (await import('./dark.module.scss')).default; | ||
const light = (await import('./light.module.scss')).default; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. had preloaded all styles at one time, cause the theme did not apply until |
||
|
||
switch (theme) { | ||
case 'dark': | ||
styles = dark; | ||
break; | ||
default: | ||
styles = light; | ||
break; | ||
} | ||
|
||
return styles; | ||
}; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We deleted these files on purpose, we dont want to use them anymore. We should define all styles in DataGridTable.module.css. Probably we want to add light-dark() postcss mixin or something like this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I rolled back changes, so we don't have a themed data grid. It is not required for now